Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for watch regression #4643

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Fix for watch regression #4643

merged 1 commit into from
Dec 7, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Dec 5, 2022 •
edited by manusa
Loading

Description

Fixes #4641 - the changes for 951a7f5 introduced a regression via a timing issue of when the websocketfuture is set.

If there is to be another 6.2 release, this should be included.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins force-pushed the int_test branch 8 times, most recently from 5535de4 to a2add7e Compare December 5, 2022 21:37
@shawkins shawkins changed the title Integration test changes Fix for watch regression Dec 5, 2022
@shawkins shawkins requested review from manusa and metacosm December 5, 2022 21:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.3.0 milestone Dec 7, 2022
@manusa manusa merged commit 0427a76 into fabric8io:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@metacosm metacosm Awaiting requested review from metacosm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

Integration Test Failures
2 participants
@shawkins @manusa